Skip to content

London|ITP-January-2026|Alexandru Pocovnicu|Sprint 2|Form controls #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandru-pocovnicu wants to merge 11 commits into
base: main
Choose a base branch
from
+60 −7
Open

London|ITP-January-2026|Alexandru Pocovnicu|Sprint 2|Form controls #943

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
98ec888
add customer details section
alexandru-pocovnicu Jan 3, 2026
6e3422a
add name attributes to customer details
alexandru-pocovnicu Jan 3, 2026
6508991
add T-shirt color selection to the form
alexandru-pocovnicu Jan 3, 2026
2d5609b
add tshirt size selection to the form
alexandru-pocovnicu Jan 3, 2026
abe821b
add required to all fields
alexandru-pocovnicu Jan 3, 2026
e9dcf1f
fix: correct label casing for T-shirt size options
alexandru-pocovnicu Jan 3, 2026
119ed06
fix: update default option for T-shirt color selection
alexandru-pocovnicu Jan 4, 2026
809dfbf
refactor: replace sections with fieldsets for better semantic structure
alexandru-pocovnicu Jan 8, 2026
0acf082
update header title
alexandru-pocovnicu Jan 8, 2026
f234fd7
fix: change footer heading from h3 to h2 for consistency
alexandru-pocovnicu Jan 8, 2026
1e4f74a
fix: update fieldset legends for consistency and improve footer headi…
alexandru-pocovnicu Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 60 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,72 @@
</head>
<body>
<header>
<h1>Product Pick</h1>
<h1>Dave's T-shirt Factory</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<fieldset>
<legend><h2>Customer's Details:</h2></legend>

<label for="customer-name"
>Name&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</label
>
<input
name="customer-name"
type="text"
minlength="2"
id="customer-name"
required
/><br /><br />
<label for="customer-surname">Surname&nbsp;&nbsp;</label>
<input
name="customer-surname"
type="text"
minlength="2"
id="customer-surname"
required
/><br /><br />

<label for="customer-email"
>E-mail&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</label
>
<input
name="customer-email"
type="email"
id="customer-email"
required
/>
</fieldset>
<fieldset>
<legend><h2> Pick a T-shirt:</h2></legend>
<label for="tshirt-color"><strong>T-shirt Color:</strong> </label>
<select name="tshirt-color" id="tshirt-color" required>
<option value="">Color</option>
<option value="yellow">Yellow</option>
<option value="green">Green</option>
<option value="burgundy">Burgundy</option>
<br /><br />
</select>
<p><strong>T-shirt Size:</strong></p>
<input name="tshirt-size" type="radio" id="xs" value="xs" required />
<label for="xs">XS</label>
<input name="tshirt-size" type="radio" id="s" value="s" />
<label for="s">S</label>
<input name="tshirt-size" type="radio" id="m" value="m" />
<label for="m">M</label>
<input name="tshirt-size" type="radio" id="l" value="l" />
<label for="l">L</label>
<input name="tshirt-size" type="radio" id="xl" value="xl" />
<label for="xl">XL</label>
<input name="tshirt-size" type="radio" id="xxl" value="xxl" />
<label for="xxl">XXL</label>
</fieldset>
<br /><br />
<input type="submit" value="Place Order" />
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h3>By Alexandru Pocovnicu</h3>
Copy link

@jenny-alexander jenny-alexander Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 You might consider using a different HTML element for your name within the footer. Right now, having <h3> in the footer will signal to screen readers that there is something new and important in the footer (like a sub-topic). In a sense, it breaks the semantic order of the page.

</footer>
</body>
</html>