-
Notifications
You must be signed in to change notification settings - Fork 324
Add test case for OF.7: empty targeting key is valid #10392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leoromanovsky
wants to merge
1
commit into
master
Choose a base branch
from
leo/ffe-of-7-empty-targeting-key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+47
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OF.7 specifies that empty string shall be accepted as a targeting key and evaluation should proceed as normal. Changes: - Added test case in DDEvaluatorTest for empty targeting key - Modified TestCase utility to use a custom EvaluationContext wrapper that preserves empty targeting keys (OpenFeature SDK's MutableContext converts empty string to null, which breaks OF.7 compliance)
9259ecf to
9d48d28
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086911
Total [baseline] (8.761 s) : 0, 8761217
Agent [candidate] (1.085 s) : 0, 1085491
Total [candidate] (8.765 s) : 0, 8764836
section iast
Agent [baseline] (1.236 s) : 0, 1236470
Total [baseline] (9.355 s) : 0, 9355352
Agent [candidate] (1.223 s) : 0, 1223020
Total [candidate] (9.334 s) : 0, 9333545
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (653.052 ms) : 0, 653052
BytebuddyAgent [candidate] (652.543 ms) : 0, 652543
GlobalTracer [baseline] (283.389 ms) : 0, 283389
GlobalTracer [candidate] (283.235 ms) : 0, 283235
AppSec [baseline] (32.74 ms) : 0, 32740
AppSec [candidate] (32.727 ms) : 0, 32727
Debugger [baseline] (67.38 ms) : 0, 67380
Debugger [candidate] (66.806 ms) : 0, 66806
Remote Config [baseline] (656.564 µs) : 0, 657
Remote Config [candidate] (632.091 µs) : 0, 632
Telemetry [baseline] (9.021 ms) : 0, 9021
Telemetry [candidate] (9.023 ms) : 0, 9023
Flare Poller [baseline] (3.862 ms) : 0, 3862
Flare Poller [candidate] (3.785 ms) : 0, 3785
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (801.868 ms) : 0, 801868
BytebuddyAgent [candidate] (791.294 ms) : 0, 791294
GlobalTracer [baseline] (258.89 ms) : 0, 258890
GlobalTracer [candidate] (256.592 ms) : 0, 256592
AppSec [baseline] (34.112 ms) : 0, 34112
AppSec [candidate] (33.358 ms) : 0, 33358
Debugger [baseline] (65.086 ms) : 0, 65086
Debugger [candidate] (65.653 ms) : 0, 65653
Remote Config [baseline] (568.621 µs) : 0, 569
Remote Config [candidate] (546.635 µs) : 0, 547
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (8.426 ms) : 0, 8426
Flare Poller [baseline] (3.618 ms) : 0, 3618
Flare Poller [candidate] (3.606 ms) : 0, 3606
IAST [baseline] (27.062 ms) : 0, 27062
IAST [candidate] (27.006 ms) : 0, 27006
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085356
Total [baseline] (10.781 s) : 0, 10780950
Agent [candidate] (1.085 s) : 0, 1084869
Total [candidate] (10.874 s) : 0, 10874215
section appsec
Agent [baseline] (1.264 s) : 0, 1263731
Total [baseline] (10.989 s) : 0, 10989003
Agent [candidate] (1.265 s) : 0, 1265401
Total [candidate] (11.075 s) : 0, 11075094
section iast
Agent [baseline] (1.225 s) : 0, 1225407
Total [baseline] (11.157 s) : 0, 11156790
Agent [candidate] (1.225 s) : 0, 1224842
Total [candidate] (11.156 s) : 0, 11155647
section profiling
Agent [baseline] (1.206 s) : 0, 1205601
Total [baseline] (10.923 s) : 0, 10923063
Agent [candidate] (1.213 s) : 0, 1212502
Total [candidate] (11.01 s) : 0, 11009696
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (652.342 ms) : 0, 652342
BytebuddyAgent [candidate] (652.152 ms) : 0, 652152
GlobalTracer [baseline] (282.473 ms) : 0, 282473
GlobalTracer [candidate] (282.654 ms) : 0, 282654
AppSec [baseline] (32.515 ms) : 0, 32515
AppSec [candidate] (32.697 ms) : 0, 32697
Debugger [baseline] (67.861 ms) : 0, 67861
Debugger [candidate] (67.22 ms) : 0, 67220
Remote Config [baseline] (655.108 µs) : 0, 655
Remote Config [candidate] (651.81 µs) : 0, 652
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (9.041 ms) : 0, 9041
Flare Poller [baseline] (3.801 ms) : 0, 3801
Flare Poller [candidate] (3.796 ms) : 0, 3796
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (690.274 ms) : 0, 690274
BytebuddyAgent [candidate] (691.279 ms) : 0, 691279
GlobalTracer [baseline] (258.589 ms) : 0, 258589
GlobalTracer [candidate] (259.104 ms) : 0, 259104
AppSec [baseline] (172.496 ms) : 0, 172496
AppSec [candidate] (172.97 ms) : 0, 172970
Debugger [baseline] (67.484 ms) : 0, 67484
Debugger [candidate] (67.133 ms) : 0, 67133
Remote Config [baseline] (731.058 µs) : 0, 731
Remote Config [candidate] (759.251 µs) : 0, 759
Telemetry [baseline] (9.219 ms) : 0, 9219
Telemetry [candidate] (9.326 ms) : 0, 9326
Flare Poller [baseline] (3.746 ms) : 0, 3746
Flare Poller [candidate] (3.785 ms) : 0, 3785
IAST [baseline] (24.555 ms) : 0, 24555
IAST [candidate] (24.476 ms) : 0, 24476
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (792.22 ms) : 0, 792220
BytebuddyAgent [candidate] (791.635 ms) : 0, 791635
GlobalTracer [baseline] (256.784 ms) : 0, 256784
GlobalTracer [candidate] (256.699 ms) : 0, 256699
AppSec [baseline] (33.538 ms) : 0, 33538
AppSec [candidate] (34.262 ms) : 0, 34262
Debugger [baseline] (66.628 ms) : 0, 66628
Debugger [candidate] (65.829 ms) : 0, 65829
Remote Config [baseline] (587.636 µs) : 0, 588
Remote Config [candidate] (580.698 µs) : 0, 581
Telemetry [baseline] (8.485 ms) : 0, 8485
Telemetry [candidate] (8.547 ms) : 0, 8547
Flare Poller [baseline] (3.542 ms) : 0, 3542
Flare Poller [candidate] (3.589 ms) : 0, 3589
IAST [baseline] (27.053 ms) : 0, 27053
IAST [candidate] (27.118 ms) : 0, 27118
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (701.691 ms) : 0, 701691
BytebuddyAgent [candidate] (707.595 ms) : 0, 707595
GlobalTracer [baseline] (221.014 ms) : 0, 221014
GlobalTracer [candidate] (222.531 ms) : 0, 222531
AppSec [baseline] (32.277 ms) : 0, 32277
AppSec [candidate] (32.379 ms) : 0, 32379
Debugger [baseline] (68.54 ms) : 0, 68540
Debugger [candidate] (68.575 ms) : 0, 68575
Remote Config [baseline] (688.549 µs) : 0, 689
Remote Config [candidate] (643.08 µs) : 0, 643
Telemetry [baseline] (9.018 ms) : 0, 9018
Telemetry [candidate] (8.917 ms) : 0, 8917
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.796 ms) : 0, 3796
ProfilingAgent [baseline] (97.554 ms) : 0, 97554
ProfilingAgent [candidate] (96.573 ms) : 0, 96573
Profiling [baseline] (98.134 ms) : 0, 98134
Profiling [candidate] (97.153 ms) : 0, 97153
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.221 ms) : 1209, 1233
. : milestone, 1221,
iast (3.265 ms) : 3225, 3305
. : milestone, 3265,
iast_FULL (5.799 ms) : 5742, 5857
. : milestone, 5799,
iast_GLOBAL (3.395 ms) : 3344, 3447
. : milestone, 3395,
profiling (1.988 ms) : 1971, 2005
. : milestone, 1988,
tracing (1.814 ms) : 1799, 1829
. : milestone, 1814,
section candidate
no_agent (1.201 ms) : 1189, 1214
. : milestone, 1201,
iast (3.222 ms) : 3180, 3264
. : milestone, 3222,
iast_FULL (5.942 ms) : 5882, 6003
. : milestone, 5942,
iast_GLOBAL (3.678 ms) : 3622, 3735
. : milestone, 3678,
profiling (1.99 ms) : 1971, 2009
. : milestone, 1990,
tracing (1.795 ms) : 1781, 1810
. : milestone, 1795,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section baseline
no_agent (18.229 ms) : 18040, 18419
. : milestone, 18229,
appsec (18.458 ms) : 18268, 18648
. : milestone, 18458,
code_origins (17.602 ms) : 17428, 17776
. : milestone, 17602,
iast (17.679 ms) : 17503, 17855
. : milestone, 17679,
profiling (18.823 ms) : 18635, 19011
. : milestone, 18823,
tracing (18.025 ms) : 17842, 18207
. : milestone, 18025,
section candidate
no_agent (17.046 ms) : 16877, 17215
. : milestone, 17046,
appsec (19.271 ms) : 19074, 19468
. : milestone, 19271,
code_origins (17.539 ms) : 17369, 17710
. : milestone, 17539,
iast (17.919 ms) : 17736, 18102
. : milestone, 17919,
profiling (18.441 ms) : 18256, 18625
. : milestone, 18441,
tracing (17.507 ms) : 17335, 17679
. : milestone, 17507,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.837 ms) : 3611, 4063
. : milestone, 3837,
iast (2.288 ms) : 2217, 2360
. : milestone, 2288,
iast_GLOBAL (2.329 ms) : 2257, 2401
. : milestone, 2329,
profiling (2.119 ms) : 2060, 2178
. : milestone, 2119,
tracing (2.107 ms) : 2050, 2164
. : milestone, 2107,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.847 ms) : 3621, 4073
. : milestone, 3847,
iast (2.28 ms) : 2208, 2352
. : milestone, 2280,
iast_GLOBAL (2.326 ms) : 2254, 2399
. : milestone, 2326,
profiling (2.136 ms) : 2077, 2195
. : milestone, 2136,
tracing (2.098 ms) : 2041, 2155
. : milestone, 2098,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~9d48d28955, baseline=1.59.0-SNAPSHOT~ebf18b14fb
dateFormat X
axisFormat %s
section baseline
no_agent (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (17.924 s) : 17924000, 17924000
. : milestone, 17924000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
tracing (14.802 s) : 14802000, 14802000
. : milestone, 14802000,
section candidate
no_agent (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
appsec (14.592 s) : 14592000, 14592000
. : milestone, 14592000,
iast (18.323 s) : 18323000, 18323000
. : milestone, 18323000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
profiling (14.559 s) : 14559000, 14559000
. : milestone, 14559000,
tracing (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
OF.7 specifies that empty string shall be accepted as a targeting key and evaluation should proceed as normal.
This test verifies that flag evaluation works correctly when the targeting key is an empty string.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]