Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ private static List<TestCase<?>> evaluateTestCases() {
new TestCase<>("default")
.flag("simple-string")
.result(new Result<>("default").reason(ERROR.name()).errorCode(TARGETING_KEY_MISSING)),
// OF.7: Empty string is a valid targeting key - evaluation should proceed as normal
new TestCase<>("default")
.flag("simple-string")
.targetingKey("")
.result(new Result<>("test-value").reason(TARGETING_MATCH.name()).variant("on")),
new TestCase<>("default")
.flag("non-existent-flag")
.targetingKey("user-123")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,21 +1,53 @@
package datadog.trace.api.openfeature.util;

import dev.openfeature.sdk.ErrorCode;
import dev.openfeature.sdk.EvaluationContext;
import dev.openfeature.sdk.MutableContext;
import dev.openfeature.sdk.Structure;
import dev.openfeature.sdk.Value;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;

public class TestCase<E> {

public Class<E> type;
public String flag;
public E defaultValue;
public final MutableContext context = new MutableContext();
private final MutableContext baseContext = new MutableContext();
private String targetingKeyOverride;
private boolean hasTargetingKeyOverride = false;
public Result<E> result;

// Custom context wrapper that preserves empty targeting key (OF.7 compliance)
public final EvaluationContext context = new EvaluationContext() {
@Override
public String getTargetingKey() {
return hasTargetingKeyOverride ? targetingKeyOverride : baseContext.getTargetingKey();
}

@Override
public Value getValue(String key) {
return baseContext.getValue(key);
}

@Override
public Set<String> keySet() {
return baseContext.keySet();
}

@Override
public Map<String, Value> asMap() {
return baseContext.asMap();
}

@Override
public Map<String, Object> asObjectMap() {
return baseContext.asObjectMap();
}
};

@SuppressWarnings("unchecked")
public TestCase(final E defaultValue) {
this.type = (Class<E>) defaultValue.getClass();
Expand All @@ -28,37 +60,39 @@ public TestCase<E> flag(String flag) {
}

public TestCase<E> targetingKey(final String targetingKey) {
context.setTargetingKey(targetingKey);
// Preserve the targeting key directly to support empty string (OF.7)
this.targetingKeyOverride = targetingKey;
this.hasTargetingKeyOverride = true;
return this;
}

public TestCase<E> context(final String key, final String value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

public TestCase<E> context(final String key, final Integer value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

public TestCase<E> context(final String key, final Double value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

public TestCase<E> context(final String key, final Boolean value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

public TestCase<E> context(final String key, final Structure value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

public TestCase<E> context(final String key, final List<Value> value) {
context.add(key, value);
baseContext.add(key, value);
return this;
}

Expand Down