Improve 2 NVML-related tests #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
kkraus14
approved these changes
Jan 29, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves 2 NVML tests.
The first is a forward port of a test fix that was required to pass on 12.9.x -- On 12.9.x, there is no
nvml.PlatformInfo_v2, so it returns annvml.PlatformInfo_v1.The other is to confirm that the current fan speed is between the known minimum and maximum. The docs don't actually specify that it must be between min and max, I had just assumed this. It is now failing very intermittently -- I think it's best to just remove it rather than having a flaky test in the set.