Skip to content

Improve 2 NVML-related tests #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 2 commits into from
Jan 29, 2026
Merged

Improve 2 NVML-related tests #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb1d579
Improve 2 NVML-related tests
mdboom Jan 29, 2026
a471936
Merge branch 'main' into nvml-improve-tests
mdboom Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cuda_bindings/tests/nvml/test_gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_gpu_get_platform_info(all_devices):
with unsupported_before(device, None):
platform_info = nvml.device_get_platform_info(device)

assert isinstance(platform_info, nvml.PlatformInfo_v2)
assert isinstance(platform_info, (nvml.PlatformInfo_v1, nvml.PlatformInfo_v2))


# TODO: Test APIs related to GPU instances, which require specific hardware and root
Expand Down
2 changes: 0 additions & 2 deletions cuda_core/tests/system/test_system_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,6 @@ def test_fan():
assert isinstance(min_, int)
assert isinstance(max_, int)
assert min_ <= max_
if speed > 0:
assert min_ <= speed <= max_

control_policy = fan_info.control_policy
assert isinstance(control_policy, system.FanControlPolicy)
Expand Down
Loading