Fix bugs with radius, blur and max. #9#17
Open
yepninja wants to merge 3 commits intoOpenGov:masterfrom
Open
Conversation
jeremiahrhall
requested changes
Oct 6, 2017
Member
jeremiahrhall
left a comment
jeremiahrhall
left a comment
There was a problem hiding this comment.
Please see my comments about the radius update check
| center: Object; | ||
| } | ||
|
|
||
| function isTrue(cond: boolean): boolean { |
Member
There was a problem hiding this comment.
What is the utility of this function over just using the value passed as cond instead?
| nextProps.blur !== this.props.blur, | ||
| ].some(isTrue), | ||
| ].every(isTrue), | ||
| ].some(isTrue) |
Member
There was a problem hiding this comment.
This formatting is really hard to read and I would be more comfortable with this if this was a set of compound boolean expressions.
Member
|
@evgeny-petukhov I merged a related fix a while back. Does the new version of this package resolve the issue you were seeing? |
|
Is there any way to create or add legend for react-leaflet-heatmap-layer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the component first rendered
updateHeatmapPropsmethod compare the same props, so nothing will be changed. I've just added variable witch contains information - is it the first call of the update method.Also I've added support of the blur.