Allow use of "nc-config" as fall back if check_lib() fails#9
Merged
mohawk2 merged 1 commit intoPDLPorters:masterfrom Jan 23, 2025
Merged
Allow use of "nc-config" as fall back if check_lib() fails#9mohawk2 merged 1 commit intoPDLPorters:masterfrom
mohawk2 merged 1 commit intoPDLPorters:masterfrom
Conversation
Contributor
Author
|
Hope this gets us most of the way there. |
Closed
Issue 8: If check_lib() fails to find the netCDF libraries, then look for `nc-config` via PATH (using `which`); if found, use the command, `nc-config --cflags` to get the include flags for the linker (-I...). `nc-config --libs` returns the lib and lib path flags. Resolves PDLPorters#8.
Member
|
I've updated the main CI for the Brave New World of >=5.16, and will force-push this rebased past that once it finishes updating the caches (which is slow for some reason). If it then passes, which it looks like it will, I'll merge and release. |
Pull Request Test Coverage Report for Build 12936462513Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 8: If check_lib() fails to find the netCDF libraries, then look for
nc-configvia PATH (usingwhich); if found, use the command,nc-config --cflagsto get the include flags for the linker (-I...).nc-config --libsreturns the lib and lib path flags.Resolves #8.