bugfix(audio): Fix particle cannon being inaudible after saveload

[stephanmeesters]

• Closes Particle Cannon Sound is not audible after saveload #2023

Fixes issue where sound from the particle cannon is not audible after saveload.

A savegame can be made during any of combinations of STATUS_ and LASERSTATUS_ below. Sounds are triggered only during state change, so when loading a savegame any of the sounds in the Active column need to be added.

Cycle sequence of beam firing vs sounds

STATUS_	LASERSTATUS_	Add	Clear	Active
PACKING (1)	NONE	none	none	none
CHARGING	NONE	powerupSound	unpackToReadySound firingToIdleSound annihilationSound	powerupSound
PREPARING	NONE	unpackToReadySound	firingToIdleSound annihilationSound	powerupSound unpackToReadySound
ALMOST_READY	NONE	none	none	powerupSound unpackToReadySound
READY_TO_FIRE	NONE	none	powerupSound firingToIdleSound annihilationSound	unpackToReadySound
PREFIRE	NONE	none	none	unpackToReadySound
FIRING	BORN	firingToIdleSound annihilationSound	powerupSound unpackToReadySound	firingToIdleSound annihilationSound
POSTFIRE	BORN	none	none	firingToIdleSound annihilationSound
PACKING (2)	DECAYING DEAD	none	none	firingToIdleSound annihilationSound
IDLE	NONE	none	powerupSound unpackToReadySound firingToIdleSound annihilationSound	none

Status meanings

• IDLE: Particle cannon is inactive and fully reset.
• CHARGING: Early pre-ready phase; charging loop plays.
• PREPARING: Antenna/deploy preparation phase.
• ALMOST_READY: Near-ready phase before final ready state.
• READY_TO_FIRE: Weapon is available and waiting for fire command.
• PREFIRE: Transitional pre-shot state (defined and checked, typically brief/rare in this flow).
• FIRING: Main active attack phase while beam is operating.
• POSTFIRE: Attack is decaying after firing window ends.
• PACKING: Pack-up phase after attack/ready path.

Laser status meanings

• NONE: No orbital beam lifecycle started yet for current cycle.
• BORN: Orbit-to-target beam was created and is in active phase.
• DECAYING: Beam is in decay/shutdown window.
• DEAD: Beam lifecycle is finished (end state before reset to NONE on next cycle setup).

Sound meanings

• powerupSound: charge, at particle cannon.
• unpackToReadySound: prep, at particle cannon.
• firingToIdleSound: firing/pack, at particle cannon.
• annihilationSound: beam-impact, at origin beam.

Todo

• Replicate to Generals

[greptile-apps]

Greptile Overview

Greptile Summary

Restores particle cannon audio after save/load by re-registering sound handles in loadPostProcess() when the cannon is in STATUS_FIRING, STATUS_POSTFIRE, or STATUS_PACKING states.

• Adds sound handle restoration for m_firingToIdleSound (cannon sound) and m_annihilationSound (beam sound)
• Mirrors the existing pattern used in setLogicalStatus() at ParticleUplinkCannonUpdate.cpp:1239-1242 and createOrbitToTargetLaser() at ParticleUplinkCannonUpdate.cpp:1052-1056
• Properly checks conditions before registering: sound event name must be non-empty, and for beam sound, beam drawable must exist

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix follows established patterns from the same codebase, properly checks preconditions, addresses a specific bug with clear reproduction steps, and only affects save/load behavior without changing runtime logic
• No files require special attention

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/ParticleUplinkCannonUpdate.cpp	Restores audio events for particle cannon sounds after save/load by re-registering sound handles in loadPostProcess() when cannon is firing

_{Last reviewed commit: 7d22e2e}

[xezon]

@bugfix

[xezon]

Why POSTFIRE and PACKING ?

Can you explain how the statuses relate to the lifetime of the 2 sounds?