tweak(worldbuilder): Remove EULA code and data

[Caball009]

Currently every launch of the (Zero Hour) World Builder requires accepting the end-user license agreement. This is unnecessarily inconvenient. The Steam version of the WB doesn't show this window, and it was pointed out to me that we're not required to show this window under GPL v3.0. This PR should remove all code and data relating to the EULA window.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Overview

Greptile Summary

Removed the EULA dialog that appeared on every Zero Hour World Builder launch, improving user experience by eliminating unnecessary interruption.

• Deleted EulaDialog.cpp and euladialog.h files
• Removed EULA dialog invocation from InitInstance() in WorldBuilder.cpp
• Removed EULA dialog resource and string definitions from WorldBuilder.rc
• Updated CMakeLists.txt to remove EULA files from build sources

The changes are clean and straightforward. Minor cleanup needed: leftover resource definitions in resource.h should be removed for completeness.

Confidence Score: 4/5

• Safe to merge with minor cleanup recommended
• The PR successfully removes all EULA code and data from the GeneralsMD World Builder. The changes are straightforward: file deletions, removal of function calls, and resource cleanup. However, unused resource definitions remain in resource.h (7 constants that should be deleted). This is a minor cleanup issue that doesn't affect functionality but should be addressed for code hygiene.
• Consider cleaning up GeneralsMD/Code/Tools/WorldBuilder/res/resource.h to remove leftover EULA-related constants

Important Files Changed

Filename	Overview
GeneralsMD/Code/Tools/WorldBuilder/res/WorldBuilder.rc	Removed EULA dialog resource and all EULA text string resources
GeneralsMD/Code/Tools/WorldBuilder/src/WorldBuilder.cpp	Removed include of euladialog.h and removed EULA dialog modal call from InitInstance()

Flowchart

flowchart TD
    A[World Builder Launch] --> B{BEFORE: EULA Dialog}
    B -->|Accept| C[Initialize Application]
    B -->|Cancel| D[Exit Application]
    C --> E[World Builder Runs]
    
    F[World Builder Launch] --> G[AFTER: Direct Initialization]
    G --> H[World Builder Runs]
    
    style B fill:#ffcccc
    style D fill:#ffcccc
    style G fill:#ccffcc
    style H fill:#ccffcc

Loading

_{Last reviewed commit: e5b11af}

[greptile-apps]

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Leftover EULA resource definitions remain in resource.h: IDD_EULA_AGREEMENT (line 134), IDC_EDIT1 (line 379), and IDS_EULA_AGREEMENT1-5 (lines 752-756). These should be removed.

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/Tools/WorldBuilder/res/WorldBuilder.rc
Line: 1693:1693

Comment:
Leftover EULA resource definitions remain in `resource.h`: `IDD_EULA_AGREEMENT` (line 134), `IDC_EDIT1` (line 379), and `IDS_EULA_AGREEMENT1-5` (lines 752-756). These should be removed.

How can I resolve this? If you propose a fix, please make it concise.