Skip to content

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Jan 19, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency in the ListTasksParamsMapper by standardizing how the historyLength parameter is processed. The change ensures that historyLength is treated as null only when it is truly unset, mirroring the robust handling already in place for pageSize and thereby improving the reliability of parameter interpretation.

Highlights

  • Consistent Parameter Mapping: The mapping logic for the historyLength parameter in ListTasksParamsMapper has been updated to align with the pageSize parameter. It now explicitly checks request.hasHistoryLength() to determine if the field is set, rather than relying on a zeroToNull qualifier.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the historyLength mapping in ListTasksParamsMapper.java to align with how pageSize is handled. By using request.hasHistoryLength(), the mapper now accurately distinguishes between an unset historyLength field (which maps to null) and an explicitly provided 0 value (which maps to 0). This change improves consistency and semantic correctness when converting Protobuf ListTasksRequest to the domain ListTasksParams, especially since 0 is a valid non-negative value for historyLength in the domain model.

@kabir kabir merged commit 4124771 into a2aproject:main Jan 19, 2026
8 checks passed
@kabir kabir deleted the list-tasks-tck branch January 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants