Skip to content

fix: Make historyLength consistent with pageSize in mapper #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Jan 19, 2026
Merged

fix: Make historyLength consistent with pageSize in mapper #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec-grpc/src/main/java/io/a2a/grpc/mapper/ListTasksParamsMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ public interface ListTasksParamsMapper {
// pageSize: Check if field is set using hasPageSize() to distinguish unset (null) from explicit 0 (validation error)
@Mapping(target = "pageSize", expression = "java(request.hasPageSize() ? request.getPageSize() : null)")
@Mapping(target = "pageToken", source = "pageToken", qualifiedByName = "emptyToNull")
@Mapping(target = "historyLength", source = "historyLength", qualifiedByName = "zeroToNull")
// historyLength: Check if field is set using hasHistoryLength() for consistency with pageSize
@Mapping(target = "historyLength", expression = "java(request.hasHistoryLength() ? request.getHistoryLength() : null)")
@Mapping(target = "lastUpdatedAfter", source = "lastUpdatedAfter", qualifiedByName = "millisToInstant")
@Mapping(target = "includeArtifacts", source = "includeArtifacts", qualifiedByName = "falseToNull")
io.a2a.spec.ListTasksParams fromProto(ListTasksRequest request);
Expand Down