feat: implement update stastics #511
Open
+565
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Jan 16, 2026
| Kind kind() const final { return Kind::kUpdateStatistics; } | ||
|
|
||
| struct ApplyResult { | ||
| std::unordered_map<int64_t, std::shared_ptr<StatisticsFile>> to_set; |
Member
There was a problem hiding this comment.
Is it cheaper to use std::vector<std::pair<int64_t, std::shared_ptr<StatisticsFile>>>?
Comment on lines
+47
to
+49
| const std::shared_ptr<StatisticsFile>& statistics_file) { | ||
| ICEBERG_BUILDER_CHECK(statistics_file != nullptr, "Statistics file cannot be null"); | ||
| statistics_to_set_[statistics_file->snapshot_id] = statistics_file; |
Member
There was a problem hiding this comment.
Suggested change
| const std::shared_ptr<StatisticsFile>& statistics_file) { | |
| ICEBERG_BUILDER_CHECK(statistics_file != nullptr, "Statistics file cannot be null"); | |
| statistics_to_set_[statistics_file->snapshot_id] = statistics_file; | |
| std::shared_ptr<StatisticsFile> statistics_file) { | |
| ICEBERG_BUILDER_CHECK(statistics_file != nullptr, "Statistics file cannot be null"); | |
| statistics_to_set_[statistics_file->snapshot_id] = std::move(statistics_file); |
Comment on lines
+191
to
+194
| // Apply statistics changes to the metadata builder | ||
| for (const auto& [snapshot_id, stat_file] : result.to_set) { | ||
| metadata_builder_->SetStatistics(stat_file); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| // Apply statistics changes to the metadata builder | |
| for (const auto& [snapshot_id, stat_file] : result.to_set) { | |
| metadata_builder_->SetStatistics(stat_file); | |
| } | |
| for (auto&& [_, stat_file] : result.to_set) { | |
| metadata_builder_->SetStatistics(std::move(stat_file)); | |
| } |
| return false; | ||
| } | ||
| const auto& other_set = static_cast<const SetStatistics&>(other); | ||
| return *statistics_file_ == *other_set.statistics_file_; |
| } | ||
|
|
||
| void TableMetadataBuilder::Impl::SetLocation(std::string_view location) { | ||
| Status TableMetadataBuilder::Impl::SetLocation(std::string_view location) { |
Member
There was a problem hiding this comment.
Why changing this? We don't need to return status if it never has any error.
| } | ||
|
|
||
| Status TableMetadataBuilder::Impl::SetStatistics( | ||
| const std::shared_ptr<StatisticsFile>& statistics_file) { |
Member
There was a problem hiding this comment.
Suggested change
| const std::shared_ptr<StatisticsFile>& statistics_file) { | |
| std::shared_ptr<StatisticsFile> statistics_file) { |
|
|
||
| Status TableMetadataBuilder::Impl::SetStatistics( | ||
| const std::shared_ptr<StatisticsFile>& statistics_file) { | ||
| ICEBERG_CHECK(statistics_file != nullptr, "Cannot set null statistics file"); |
Member
There was a problem hiding this comment.
Suggested change
| ICEBERG_CHECK(statistics_file != nullptr, "Cannot set null statistics file"); | |
| ICEBERG_PRECHECK(statistics_file != nullptr, "Cannot set null statistics file"); |
Note that PRECHECK returns InvalidArgument while CHECK returns ValidationFailed.
| metadata_.statistics.push_back(statistics_file); | ||
| } | ||
|
|
||
| changes_.push_back(std::make_unique<table::SetStatistics>(statistics_file)); |
| } | ||
|
|
||
| // Remove statistics for the given snapshot_id | ||
| std::erase_if(metadata_.statistics, [snapshot_id](const auto& stat) { |
Member
There was a problem hiding this comment.
Can we combine find and erase in a single call?
Member
There was a problem hiding this comment.
Or you can just call something like metadata_.statistics.erase(it) to avoid a 2nd iteration
| json[kLocation] = u.location(); | ||
| break; | ||
| } | ||
| case TableUpdate::Kind::kSetStatistics: { |
Member
There was a problem hiding this comment.
Please also add FromJson equivalents and their test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.