Refactor integration test core into a new 'obo-tests' crate#60
Merged
Conversation
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
2fa48b7 to
4ced142
Compare
Contributor
|
@refi64 as a first pass can you fix CI and the conflicts? |
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
4ced142 to
cb034e3
Compare
Collaborator
Author
|
@sjoerdsimons conflicts fixed, I don't think |
refi64
force-pushed
the
wip/refi64/commander-tests
branch
2 times, most recently
from
fe73a54 to
fb9b128
Compare
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
fb9b128 to
44c397f
Compare
refi64
force-pushed
the
wip/refi64/commander-tests
branch
3 times, most recently
from
0a098a8 to
0f81984
Compare
refi64
force-pushed
the
wip/refi64/commander-tests
branch
2 times, most recently
from
10135e3 to
4661b3f
Compare
refi64
changed the title
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
4661b3f to
9d78d16
Compare
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
9d78d16 to
ad3e0a6
Compare
Most of this logic is rather intricate and shareable between multiple implementations, so it makes sense for them to be in a separate crate. This necessitates quite a bit of refactoring of the test structure so that the shared test code can actually run commands and inspect the logs + artifacts. Since there are various somewhat strange requirements around command execution (i.e. needing to use timeouts but still get the result), that API was redone around a builder trait, which also makes it easy for implementation-specific tests to have their own methods on it.
refi64
force-pushed
the
wip/refi64/commander-tests
branch
from
ad3e0a6 to
ab9b0b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As usual, only the last commit is new, depends on #58.