Refactor integration test core into a new 'obo-tests' crate #60
Annotations
8 warnings
|
Run clechasseur/rs-clippy-check@v5.0.1:
obs-gitlab-runner/src/handler.rs#L416
warning: this `if` statement can be collapsed
--> obs-gitlab-runner/src/handler.rs:416:5
|
416 | / if let Some(mut artifact) = dep.download().await? {
417 | | if let Some(file) = tokio::task::spawn_blocking(move || {
418 | | artifact
419 | | .file(path.as_str())
... |
434 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
416 ~ if let Some(mut artifact) = dep.download().await?
417 ~ && let Some(file) = tokio::task::spawn_blocking(move || {
418 | artifact
...
432 | ));
433 ~ }
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obs-gitlab-runner/src/handler.rs#L416
warning: this `if` statement can be collapsed
--> obs-gitlab-runner/src/handler.rs:416:5
|
416 | / if let Some(mut artifact) = dep.download().await? {
417 | | if let Some(file) = tokio::task::spawn_blocking(move || {
418 | | artifact
419 | | .file(path.as_str())
... |
434 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
416 ~ if let Some(mut artifact) = dep.download().await?
417 ~ && let Some(file) = tokio::task::spawn_blocking(move || {
418 | artifact
...
432 | ));
433 ~ }
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/prune.rs#L48
warning: this `if` statement can be collapsed
--> obo-core/src/prune.rs:48:5
|
48 | / if let Some(expected_rev) = expected_rev {
49 | | if dir.rev.as_deref() != Some(expected_rev) {
50 | | outputln!(
51 | | "Latest revision is {}, skipping prune",
... |
56 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
48 ~ if let Some(expected_rev) = expected_rev
49 ~ && dir.rev.as_deref() != Some(expected_rev) {
50 | outputln!(
...
54 | return Ok(());
55 ~ }
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/prune.rs#L48
warning: this `if` statement can be collapsed
--> obo-core/src/prune.rs:48:5
|
48 | / if let Some(expected_rev) = expected_rev {
49 | | if dir.rev.as_deref() != Some(expected_rev) {
50 | | outputln!(
51 | | "Latest revision is {}, skipping prune",
... |
56 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
48 ~ if let Some(expected_rev) = expected_rev
49 ~ && dir.rev.as_deref() != Some(expected_rev) {
50 | outputln!(
...
54 | return Ok(());
55 ~ }
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/build_meta.rs#L244
warning: called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead
--> obo-core/src/build_meta.rs:244:43
|
244 | let prev_endtime_for_commit = jobhist
| ___________________________________________^
245 | | .jobhist
246 | | .iter()
247 | | .filter(|e| e.srcmd5 == srcmd5)
248 | | .next_back()
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
244 ~ let prev_endtime_for_commit = jobhist
245 + .jobhist
246 + .iter().rfind(|e| e.srcmd5 == srcmd5)
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/build_meta.rs#L124
warning: this `if` statement can be collapsed
--> obo-core/src/build_meta.rs:124:21
|
124 | / if let Some(obs::Error::ApiError(obs::ApiError { code, .. })) =
125 | | cause.downcast_ref::<obs::Error>()
126 | | {
127 | | if code == "unknown_package" {
... |
130 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
125 ~ cause.downcast_ref::<obs::Error>()
126 ~ && code == "unknown_package" {
127 | return Ok(None);
128 ~ }
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/build_meta.rs#L244
warning: called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead
--> obo-core/src/build_meta.rs:244:43
|
244 | let prev_endtime_for_commit = jobhist
| ___________________________________________^
245 | | .jobhist
246 | | .iter()
247 | | .filter(|e| e.srcmd5 == srcmd5)
248 | | .next_back()
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
244 ~ let prev_endtime_for_commit = jobhist
245 + .jobhist
246 + .iter().rfind(|e| e.srcmd5 == srcmd5)
|
|
|
Run clechasseur/rs-clippy-check@v5.0.1:
obo-core/src/build_meta.rs#L124
warning: this `if` statement can be collapsed
--> obo-core/src/build_meta.rs:124:21
|
124 | / if let Some(obs::Error::ApiError(obs::ApiError { code, .. })) =
125 | | cause.downcast_ref::<obs::Error>()
126 | | {
127 | | if code == "unknown_package" {
... |
130 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
125 ~ cause.downcast_ref::<obs::Error>()
126 ~ && code == "unknown_package" {
127 | return Ok(None);
128 ~ }
|
|
Loading