Make close() idempotent for already-closed connections#1044
Merged
bimalkjha merged 1 commit intoibmdb:masterfrom Feb 19, 2026
Merged
Make close() idempotent for already-closed connections#1044bimalkjha merged 1 commit intoibmdb:masterfrom
bimalkjha merged 1 commit intoibmdb:masterfrom
Conversation
Contributor
Author
|
@Earammak Please let me know if I should do anything for this failing DCO check |
zenflow
force-pushed
the
idempotent-close-method
branch
from
14f2ce7 to
45f5496
Compare
Return True when ibm_db.close() or ibm_db_dbi.Connection.close() is called on an already-closed connection instead of raising. Add a DBI regression test for double-close behavior.
zenflow
force-pushed
the
idempotent-close-method
branch
from
45f5496 to
86fd270
Compare
Contributor
Author
|
Sorry for the force push. |
bimalkjha
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return True when ibm_db.close() or ibm_db_dbi.Connection.close() is called on an already-closed connection instead of raising.
Add a DBI regression test for double-close behavior.
Closes #1042
The new test passes, but I was unable to run the whole test suite to check for regressions, as I'm not able to create an isolated database instance.
Can someone run the whole test suite and confirm all pass?