Fixes to --security-advisories option
#479
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
If I read the GitHub docs correctly:
I am pretty sure that private repos can never have security advisories. This seems to match with my tests. It looks like I originally didn't test the argument with a private repo at all because I thought there was no point as I didn't have one with security advisories. Now I know why 🙄, sorry for that regression.
Summary of changes
security-advisoriessubdirectory is not created. This avoids empty directories for repos that cannot have security advisories.--allis modified such that it skips security advisories on private repos by default. If a user still wants to try to back up security advisories, they can (additionally) provide the--security-advisoriesargument to overrule this default. I think this behavior should be the best of both worlds.