Skip to content

Fixes to --security-advisories option #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasbestle wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes to --security-advisories option #479

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93e505c
fix: Handle 404 errors on security advisories
lukasbestle Jan 14, 2026
c6fa8c7
feat: Only make security advisory dir if successful
lukasbestle Jan 14, 2026
856ad5d
fix: Skip security advisories for private repos unless explicitly req…
lukasbestle Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions github_backup/github_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,7 +1814,7 @@ def backup_repositories(args, output_directory, repositories):
if args.include_milestones or args.include_everything:
backup_milestones(args, repo_cwd, repository, repos_template)

if args.include_security_advisories or args.include_everything:
if args.include_security_advisories or (args.include_everything and not repository["Private"]):
backup_security_advisories(args, repo_cwd, repository, repos_template)

if args.include_labels or args.include_everything:
Expand Down Expand Up @@ -2039,13 +2039,20 @@ def backup_security_advisories(args, repo_cwd, repository, repos_template):
return

logger.info("Retrieving {0} security advisories".format(repository["full_name"]))
mkdir_p(repo_cwd, advisory_cwd)

template = "{0}/{1}/security-advisories".format(
repos_template, repository["full_name"]
)

_advisories = retrieve_data(args, template)
try:
_advisories = retrieve_data(args, template)
except Exception as e:
if "404" in str(e):
logger.info("Security advisories are not available for this repository, skipping")
return
raise

mkdir_p(repo_cwd, advisory_cwd)

advisories = {}
for advisory in _advisories:
Expand Down