Refactor theme tokens: add surfaceGlass and standardize breakpoints#767
Open
marcodejongh wants to merge 1 commit intomainfrom
Open
Refactor theme tokens: add surfaceGlass and standardize breakpoints#767marcodejongh wants to merge 1 commit intomainfrom
marcodejongh wants to merge 1 commit intomainfrom
Conversation
- Add `surfaceGlass` semantic token for frosted glass background color - Add `breakpoints.mobile` constant (768px) for mobile/desktop media queries - Use theme constants in bottom-tab-bar.tsx instead of hardcoded rgba and media query - Add corresponding `--semantic-surface-glass` CSS variable - Document why !important is needed on background-color in index.css (overrides MUI CssBaseline's Emotion-injected styles) https://claude.ai/code/session_01XMnEqXu6R4M4sjuUdgmQsy
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude Review✅ Ready to merge - No significant issues found. This is a clean refactor that extracts hardcoded values into theme tokens ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves theme consistency and maintainability by extracting hardcoded values into centralized theme tokens. Specifically, it adds a new
surfaceGlasssemantic color for frosted glass effects and introduces a standardizedbreakpointsobject for responsive design.Key Changes
surfaceGlasssemantic color: New theme tokenrgba(255, 255, 255, 0.3)for frosted glass effect backgrounds, replacing hardcoded valuesthemeTokens.breakpoints.mobile(768px) as a single source of truth for mobile/desktop transitionsthemeTokens.semantic.surfaceGlassthemeTokens.breakpoints.mobile--semantic-surface-glassto index.css for consistency!importantusage on background-color to override MUI's CssBaselineImplementation Details
surfaceGlasstoken is specifically designed for semi-transparent overlay backgrounds with blur effects (glassmorphism pattern)https://claude.ai/code/session_01XMnEqXu6R4M4sjuUdgmQsy