Skip to content

Refactor theme tokens: add surfaceGlass and standardize breakpoints #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcodejongh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor theme tokens: add surfaceGlass and standardize breakpoints #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web/app/components/bottom-tab-bar/bottom-tab-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,13 +281,13 @@ function BottomTabBar({ boardDetails, angle, boardConfigs }: BottomTabBarProps)
onChange={handleTabChange}
showLabels
sx={{
background: 'rgba(255, 255, 255, 0.3)',
background: themeTokens.semantic.surfaceGlass,
WebkitBackdropFilter: 'blur(5px)',
backdropFilter: 'blur(5px)',
borderRadius: `${themeTokens.borderRadius.xl}px`,
py: `${themeTokens.spacing[2]}px`,
height: 'auto',
'@media (min-width: 768px)': { display: 'none' },
[`@media (min-width: ${themeTokens.breakpoints.mobile}px)`]: { display: 'none' },
}}
>
<BottomNavigationAction
Expand Down
5 changes: 4 additions & 1 deletion packages/web/app/components/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
--semantic-background: #F9FAFB;
--semantic-surface: #FFFFFF;
--semantic-surface-overlay: rgba(255, 255, 255, 0.95);
--semantic-surface-glass: rgba(255, 255, 255, 0.3);
--semantic-selected: #F7F2F3;
--semantic-selected-hover: #EFE6E8;
--semantic-selected-light: rgba(140, 74, 82, 0.06);
Expand All @@ -45,7 +46,9 @@
--border-subtle: rgba(0, 0, 0, 0.06);
}

/* Base styles */
/* Base styles
Note: !important on background-color is required to override MUI's CssBaseline,
which sets its own background-color with high specificity via Emotion styles. */
html {
touch-action: manipulation;
background-color: var(--semantic-surface) !important;
Expand Down
6 changes: 6 additions & 0 deletions packages/web/app/theme/theme-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const themeTokens = {
surface: '#FFFFFF',
surfaceElevated: '#FFFFFF',
surfaceOverlay: 'rgba(255, 255, 255, 0.95)', // Semi-transparent overlay
surfaceGlass: 'rgba(255, 255, 255, 0.3)', // Frosted glass effect background
overlayLight: 'rgba(0, 0, 0, 0.3)', // Light dark overlay for hover states
overlayDark: 'rgba(0, 0, 0, 0.6)', // Dark overlay for text backgrounds
},
Expand Down Expand Up @@ -129,6 +130,11 @@ export const themeTokens = {
slow: '300ms ease',
},

// Breakpoints - standardized across the app for mobile/desktop transitions
breakpoints: {
mobile: 768, // Below this is mobile, at/above is desktop
},

// Z-index scale
zIndex: {
dropdown: 1000,
Expand Down
Loading