-
Notifications
You must be signed in to change notification settings - Fork 5
docs: add ADR on Course Authoring Migration Process Details #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @rodmgwgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| - **Flag disabled**: New system role assignments migrate to legacy system and are removed | ||
| from new system | ||
|
|
||
| *Note: Roles without legacy equivalents remain in the new system and are not migrated* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out the case where a legacy role doesn’t have an equivalent in the new system. When the flag is enabled, would it become orphaned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a closer read, it seems this scenario won’t occur because all legacy roles will exist in the new system, while not all new-system roles exist in the legacy system. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I think all legacy roles should have equivalents on the new system, I think that's easy to achieve.
0ac29d4 to
385e76d
Compare
This PR adds an ADR specifying the implementation strategy for the Migration Process for Course Authoring AuthZ.
Related issue: #184
Merge checklist:
Check off if complete or not applicable: