[derive] Move find_zero_variant to enum module

[joshlf]

---

• 　 [WIP][derive] Factor out unsafe impl block building #2893
• 　 [derive] Introduce Ctx type #2890
• 👉 [derive] Move find_zero_variant to enum module #2889
• 　 [derive] Split repr(C) logic from derive_known_layout_inner #2888

Latest Update: v5 — Compare vs v4

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v4	v3	v2	v1	Base
v5	vs v4	vs v3	vs v2	vs v1	vs Base
v4		vs v3	vs v2	vs v1	vs Base
v3			vs v2	vs v1	vs Base
v2				vs v1	vs Base
v1					vs Base

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the zerocopy-derive crate by relocating the find_zero_variant utility function. This function, responsible for identifying enum variants with a zero discriminant, has been moved from the main lib.rs file to the more appropriate enum.rs module. This change enhances the modularity and organization of the codebase, ensuring that enum-specific logic resides in its dedicated location.

Highlights

• Code Relocation: The find_zero_variant function has been moved from zerocopy-derive/src/lib.rs to zerocopy-derive/src/enum.rs.
• Code Organization: This refactoring improves modularity by placing enum-specific logic in its dedicated module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the find_zero_variant function by moving it into the enum module. The change is a good improvement for code organization. I've added one suggestion to further improve the readability and maintainability of the moved function by reducing some code duplication.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (51c8f9d) to head (6621dbc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2889   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          20       20           
  Lines        5877     5877           
=======================================
  Hits         5401     5401           
  Misses        476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.