-
Notifications
You must be signed in to change notification settings - Fork 137
[derive] Introduce Ctx type #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Ctx type to bundle DeriveInput and zerocopy_crate path, which are frequently passed together. This is a great refactoring that simplifies many function signatures and improves code maintainability. The changes are applied consistently across the derive macro codebase. I have one minor suggestion to improve performance slightly by moving a variable assignment out of a loop. Overall, this is a solid improvement.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2890 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5877 5877
=======================================
Hits 5401 5401
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5b5202c to
9fa5e12
Compare
ed55ddf to
857dfdb
Compare
9fa5e12 to
c6141ac
Compare
afd2f14 to
cd9f80a
Compare
c6141ac to
52dc827
Compare
52dc827 to
9fcaf05
Compare
f96e8d5 to
9273914
Compare
9273914 to
6621dbc
Compare
Use the `Ctx` type to carry the `DeriveInput` and `zerocopy_crate: Path` values which are used by most functions. gherrit-pr-id: G0662505d5901f5c3cd21b16c314b9f3f8dc817a6
9fcaf05 to
6ebdd8e
Compare
Use the
Ctxtype to carry theDeriveInputandzerocopy_crate: Pathvalues which are used by most functions.
unsafe implblock building #2893Latest Update: v6 — Compare vs v5
📚 Full Patch History
Links show the diff between the row version and the column version.