Skip to content

[ET-VK][quantization] Implement layout-flexible quantize/dequantize operators#17106

Open
SS-JIA wants to merge 3 commits intogh/SS-JIA/399/basefrom
gh/SS-JIA/399/head
Open

[ET-VK][quantization] Implement layout-flexible quantize/dequantize operators#17106
SS-JIA wants to merge 3 commits intogh/SS-JIA/399/basefrom
gh/SS-JIA/399/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 2, 2026

Stack from ghstack (oldest at bottom):

Implemented quantize_per_tensor and dequantize_per_tensor GLSL shaders
and C++ dispatch logic to support the new single-dimension packed INT8 layouts
(kPackedInt8_4W, kPackedInt8_4C, kPackedInt8_4H). These operators enable
conversion between floating-point tensors and packed int8 representations with
per-tensor scale and zero-point parameters.

The implementation includes:

  • GLSL shaders: quantize_per_tensor and dequantize_per_tensor with support for
    both texture->buffer and buffer->buffer data flows, including GL_EXT_debug_printf
    statements for debugging
  • QuantizeDequantize.cpp: Added dispatch functions for the new layouts and
    registered etvk.q_dq_8bit_per_tensor.default operator
  • Test infrastructure: Created q_dq_8bit_per_tensor test binary with DEBUG_MODE
    support and reference CPU implementation for validation

The shaders implement the quantization formula Q = clamp(round(x/scale) + zp, -128, 127)
and dequantization formula x' = (Q - zp) * scale, with proper int8 packing/unpacking
using little-endian byte ordering and sign extension.

Differential Revision: D92061370

…perators

Implemented quantize_per_tensor and dequantize_per_tensor GLSL shaders
and C++ dispatch logic to support the new single-dimension packed INT8 layouts
(kPackedInt8_4W, kPackedInt8_4C, kPackedInt8_4H). These operators enable
conversion between floating-point tensors and packed int8 representations with
per-tensor scale and zero-point parameters.

The implementation includes:
- GLSL shaders: quantize_per_tensor and dequantize_per_tensor with support for
  both texture->buffer and buffer->buffer data flows, including GL_EXT_debug_printf
  statements for debugging
- QuantizeDequantize.cpp: Added dispatch functions for the new layouts and
  registered etvk.q_dq_8bit_per_tensor.default operator
- Test infrastructure: Created q_dq_8bit_per_tensor test binary with DEBUG_MODE
  support and reference CPU implementation for validation

The shaders implement the quantization formula Q = clamp(round(x/scale) + zp, -128, 127)
and dequantization formula x' = (Q - zp) * scale, with proper int8 packing/unpacking
using little-endian byte ordering and sign extension.

Differential Revision: [D92061370](https://our.internmc.facebook.com/intern/diff/D92061370/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17106

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 67f063b with merge base 477867a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…equantize operators"

Implemented quantize_per_tensor and dequantize_per_tensor GLSL shaders
and C++ dispatch logic to support the new single-dimension packed INT8 layouts
(kPackedInt8_4W, kPackedInt8_4C, kPackedInt8_4H). These operators enable
conversion between floating-point tensors and packed int8 representations with
per-tensor scale and zero-point parameters.

The implementation includes:
- GLSL shaders: quantize_per_tensor and dequantize_per_tensor with support for
  both texture->buffer and buffer->buffer data flows, including GL_EXT_debug_printf
  statements for debugging
- QuantizeDequantize.cpp: Added dispatch functions for the new layouts and
  registered etvk.q_dq_8bit_per_tensor.default operator
- Test infrastructure: Created q_dq_8bit_per_tensor test binary with DEBUG_MODE
  support and reference CPU implementation for validation

The shaders implement the quantization formula Q = clamp(round(x/scale) + zp, -128, 127)
and dequantization formula x' = (Q - zp) * scale, with proper int8 packing/unpacking
using little-endian byte ordering and sign extension.

Differential Revision: [D92061370](https://our.internmc.facebook.com/intern/diff/D92061370/)

[ghstack-poisoned]
…equantize operators"

Implemented quantize_per_tensor and dequantize_per_tensor GLSL shaders
and C++ dispatch logic to support the new single-dimension packed INT8 layouts
(kPackedInt8_4W, kPackedInt8_4C, kPackedInt8_4H). These operators enable
conversion between floating-point tensors and packed int8 representations with
per-tensor scale and zero-point parameters.

The implementation includes:
- GLSL shaders: quantize_per_tensor and dequantize_per_tensor with support for
  both texture->buffer and buffer->buffer data flows, including GL_EXT_debug_printf
  statements for debugging
- QuantizeDequantize.cpp: Added dispatch functions for the new layouts and
  registered etvk.q_dq_8bit_per_tensor.default operator
- Test infrastructure: Created q_dq_8bit_per_tensor test binary with DEBUG_MODE
  support and reference CPU implementation for validation

The shaders implement the quantization formula Q = clamp(round(x/scale) + zp, -128, 127)
and dequantization formula x' = (Q - zp) * scale, with proper int8 packing/unpacking
using little-endian byte ordering and sign extension.

Differential Revision: [D92061370](https://our.internmc.facebook.com/intern/diff/D92061370/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant