Skip to content

[ET-VK][testing] Create dedicated test binary for pointwise convolutions#17220

Open
SS-JIA wants to merge 1 commit intogh/SS-JIA/409/basefrom
gh/SS-JIA/409/head
Open

[ET-VK][testing] Create dedicated test binary for pointwise convolutions#17220
SS-JIA wants to merge 1 commit intogh/SS-JIA/409/basefrom
gh/SS-JIA/409/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 4, 2026

Stack from ghstack (oldest at bottom):

This commit creates a dedicated test binary for pointwise (1x1) convolutions
(test_q8ta_conv2d_pw), separating them from the general 2D convolution tests.
Here are the key changes:

What Changed

  1. New Test Binary: test_q8ta_conv2d_pw.cpp (591 lines)

    • Dedicated test file focusing exclusively on pointwise convolutions (kernel
      size 1x1)
    • Contains 9 test configurations ranging from accuracy tests to performance
      cases:
      • Accuracy tests: Various channel configurations (32→3, 64→32, 96→64, 13→7,
        80→40) with different spatial dimensions
      • Performance tests: Larger configurations (160→480, 22→48, 48→48, 128→128)
        exceeding the 100-dim reference limit
    • Tests all combinations of:
      • Storage types: Texture3D, Buffer
      • Int8 memory layouts: 4C1W, 4W4C, 4C
    • Also tests legacy 4W4C implementation via impl_selector="legacy_4w4c"
    • Includes full reference implementation for numerical correctness
      verification
    • Custom FLOP calculator for performance measurements
  2. Removed from test_q8ta_conv2d.cpp (44 lines deleted)

    • Removed 6 pointwise convolution configurations that are now covered by the
      new dedicated binary
    • General conv2d tests now focus solely on kernels > 1x1 (3x3, 5x5, etc.)
  3. Build System Updates

    • Added test_q8ta_conv2d_pw target to:
      • targets.bzl (Buck2)
      • CMakeLists.txt (CMake)
    • Both fbcode and xplat paths updated (files are mirrored)
  4. CI/Workflow Integration

    • Updated executorch_vulkan_eureka_unit_tests.sky to include the new test
      binary in on-device testing workflow

Why This Separation?

Pointwise convolutions (1x1 kernels) are a distinct optimization target with
different performance characteristics than general convolutions. Separating them
enables:

  • Focused performance iteration on pointwise-specific shaders
  • Cleaner test organization
  • Faster test runs when only testing one convolution type

Differential Revision: D92307251

This commit creates a dedicated test binary for pointwise (1x1) convolutions
(test_q8ta_conv2d_pw), separating them from the general 2D convolution tests.
Here are the key changes:

What Changed

1. New Test Binary: test_q8ta_conv2d_pw.cpp (591 lines)

   - Dedicated test file focusing exclusively on pointwise convolutions (kernel
     size 1x1)
   - Contains 9 test configurations ranging from accuracy tests to performance
     cases:
     - Accuracy tests: Various channel configurations (32→3, 64→32, 96→64, 13→7,
       80→40) with different spatial dimensions
     - Performance tests: Larger configurations (160→480, 22→48, 48→48, 128→128)
       exceeding the 100-dim reference limit
   - Tests all combinations of:
     - Storage types: Texture3D, Buffer
     - Int8 memory layouts: 4C1W, 4W4C, 4C
   - Also tests legacy 4W4C implementation via impl_selector="legacy_4w4c"
   - Includes full reference implementation for numerical correctness
     verification
   - Custom FLOP calculator for performance measurements

2. Removed from test_q8ta_conv2d.cpp (44 lines deleted)

   - Removed 6 pointwise convolution configurations that are now covered by the
     new dedicated binary
   - General conv2d tests now focus solely on kernels > 1x1 (3x3, 5x5, etc.)

3. Build System Updates

   - Added test_q8ta_conv2d_pw target to:
     - targets.bzl (Buck2)
     - CMakeLists.txt (CMake)
   - Both fbcode and xplat paths updated (files are mirrored)

4. CI/Workflow Integration

   - Updated executorch_vulkan_eureka_unit_tests.sky to include the new test
     binary in on-device testing workflow

Why This Separation?

Pointwise convolutions (1x1 kernels) are a distinct optimization target with
different performance characteristics than general convolutions. Separating them
enables:

- Focused performance iteration on pointwise-specific shaders
- Cleaner test organization
- Faster test runs when only testing one convolution type

Differential Revision: [D92307251](https://our.internmc.facebook.com/intern/diff/D92307251/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17220

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 5 Unrelated Failures

As of commit 4752b4d with merge base 477867a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant