Skip to content

[ET-VK][ez] Implement helper functions to get fastest moving dim#17107

Open
SS-JIA wants to merge 3 commits intogh/SS-JIA/400/basefrom
gh/SS-JIA/400/head
Open

[ET-VK][ez] Implement helper functions to get fastest moving dim#17107
SS-JIA wants to merge 3 commits intogh/SS-JIA/400/basefrom
gh/SS-JIA/400/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 2, 2026

Stack from ghstack (oldest at bottom):

Add C++ and GLSL helpers to query the fastest moving dimension (the
dimension with stride 1 in buffer layout). This is useful for optimizing
memory access patterns in shaders, as iterating along the fastest moving
dimension maximizes cache locality.

The C++ fastest_whcn_dim() method accounts for block-transposed layouts by
returning outer_packed_dim instead of packed_dim when applicable. A
corresponding GLSL macro extracts this info from the hashed layout.

Differential Revision: D92061369

Add C++ and GLSL helpers to query the fastest moving dimension (the
dimension with stride 1 in buffer layout). This is useful for optimizing
memory access patterns in shaders, as iterating along the fastest moving
dimension maximizes cache locality.

The C++ `fastest_whcn_dim()` method accounts for block-transposed layouts by
returning `outer_packed_dim` instead of `packed_dim` when applicable. A
corresponding GLSL macro extracts this info from the hashed layout.

Differential Revision: [D92061369](https://our.internmc.facebook.com/intern/diff/D92061369/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17107

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit 73b4a69 with merge base 477867a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ng dim"

Add C++ and GLSL helpers to query the fastest moving dimension (the
dimension with stride 1 in buffer layout). This is useful for optimizing
memory access patterns in shaders, as iterating along the fastest moving
dimension maximizes cache locality.

The C++ `fastest_whcn_dim()` method accounts for block-transposed layouts by
returning `outer_packed_dim` instead of `packed_dim` when applicable. A
corresponding GLSL macro extracts this info from the hashed layout.

Differential Revision: [D92061369](https://our.internmc.facebook.com/intern/diff/D92061369/)

[ghstack-poisoned]
…ng dim"

Add C++ and GLSL helpers to query the fastest moving dimension (the
dimension with stride 1 in buffer layout). This is useful for optimizing
memory access patterns in shaders, as iterating along the fastest moving
dimension maximizes cache locality.

The C++ `fastest_whcn_dim()` method accounts for block-transposed layouts by
returning `outer_packed_dim` instead of `packed_dim` when applicable. A
corresponding GLSL macro extracts this info from the hashed layout.

Differential Revision: [D92061369](https://our.internmc.facebook.com/intern/diff/D92061369/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant